Workaround build warnings with OpenSSL 1.1
Closed this issue · 1 comments
d1vanov commented
From OpenSUSE build service logs when building on Arch Linux:
[ 292s] [ 43%] Building CXX object CMakeFiles/libqt5quentier.dir/src/utility/EncryptionManager_p.cpp.o
[ 294s] /usr/src/packages/BUILD/libquentier/src/libquentier-0.4.0.git.1528533013.1b21065/src/utility/EncryptionManager_p.cpp: In constructor 'quentier::EncryptionManagerPrivate::EncryptionManagerPrivate()':
[ 294s] /usr/src/packages/BUILD/libquentier/src/libquentier-0.4.0.git.1528533013.1b21065/src/utility/EncryptionManager_p.cpp:51:24: warning: 'void OPENSSL_config(const char*)' is deprecated [-Wdeprecated-declarations]
[ 294s] OPENSSL_config(NULL);
[ 294s] ^
[ 294s] In file included from /usr/include/openssl/ct.h:13,
[ 294s] from /usr/include/openssl/ssl.h:61,
[ 294s] from /usr/src/packages/BUILD/libquentier/src/libquentier-0.4.0.git.1528533013.1b21065/src/utility/EncryptionManager_p.cpp:23:
[ 294s] /usr/include/openssl/conf.h:92:1: note: declared here
[ 294s] DEPRECATEDIN_1_1_0(void OPENSSL_config(const char *config_name))
[ 294s] ^~~~~~~~~~~~~~~~~~
[ 294s] /usr/src/packages/BUILD/libquentier/src/libquentier-0.4.0.git.1528533013.1b21065/src/utility/EncryptionManager_p.cpp:51:24: warning: 'void OPENSSL_config(const char*)' is deprecated [-Wdeprecated-declarations]
[ 294s] OPENSSL_config(NULL);
[ 294s] ^
[ 294s] In file included from /usr/include/openssl/ct.h:13,
[ 294s] from /usr/include/openssl/ssl.h:61,
[ 294s] from /usr/src/packages/BUILD/libquentier/src/libquentier-0.4.0.git.1528533013.1b21065/src/utility/EncryptionManager_p.cpp:23:
[ 294s] /usr/include/openssl/conf.h:92:1: note: declared here
[ 294s] DEPRECATEDIN_1_1_0(void OPENSSL_config(const char *config_name))
[ 294s] ^~~~~~~~~~~~~~~~~~
It looks like since OpenSSL 1.1 neither manual resources allocation nor their freeing is required - the library handles it on its own. At least that's what was written about it on OpenSSL man pages: 1, 2. Also, this changeset to nginx for the proper support of OpenSSL 1.1 is quite self-explanatory.
d1vanov commented
Fixed in commit 0870d17 in branch development.