d2a4u/meteor

Consider Removing Limit From Query Interface

Closed this issue · 4 comments

Limit is an optional parameter to the Query API: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_Query.html#DDB-Query-request-Limit

When not sent, AWS automatically limits the data to around 1MB. Being forced to pick a value to exceed that amount adds friction to using the API. Since Meteor automatically pages through using lastEvaluatedKey, setting a limit doesn't seem to be of value, as it doesn't limit how many records Meteor returns, just the size of a batch.

d2a4u commented

That sounds good to me. It would be amazing if you can raise a PR to remove limit parameter

Ok, I've got two branches, let me know which one you'd prefer as the PR:

d2a4u commented

Hi, sorry for late reply. My laptop is dead and getting a new one is quite difficult atm. Deprecation branch looks good to me. Thanks

Closed in #240