d2iq/ui-kit

Refactor Clickable Component

Closed this issue · 5 comments

nataliepina commented

Description

This issue is related to refactoring the Clickable Component.

Acceptance Criteria

Refactor the component from a class component to a function component.
Feel free to contribute other improvements to the component while refactoring if you notice any.

Refer to other components to keep formatting consistent. For example, reference the Badge, BadgeButton, or Tabs components.

How to Contribute

Please review the contributing documentation beforehand.

Steps to Contribute:

  1. Fork the repository.
  2. Clone it to your local system.
  3. Create a new branch. Please adhere to branch formatting, for example <your_initials>/refactor/<component_name>
  4. Make your changes. Make sure that tests are still passing. To update snapshot tests, run npm run test -- -u and include the updated tests in your commit.
  5. Commit your changes. When committing be sure to prefix with the appropriate conventional commit type. For example, refactor: button component.
  6. Push up your changes. In GitHub, click the compare & pull request button to begin drafting your pull request.
  7. Fill out the pull request form and attach the "ready to review" label when complete.
vishnuvnathan commented

Hi @nataliepina can you assign me this task?

  • 👍1
  • 🚀1
nataliepina commented

Hi @vishnusnathann any progress on this issue? Please let us know if you need any help. Thanks!

vishnuvnathan commented

@nataliepina I was able to update the component to FC but the tests were getting failed.

nataliepina commented

@nataliepina I was able to update the component to FC but the tests were getting failed.

Had you updated the snapshots with npm run test -- -u, try that out if not. Otherwise, if you can push up the code and create a pull request we'd be happy to take a look and offer some suggestions to fix the tests.

vishnuvnathan commented

Hi @nataliepina Created the PR #808