Refactor button from a class component to a function component
Closed this issue · 7 comments
Description
This issue is related to refactoring the ButtonBase Component.
Acceptance Criteria
Refactor the ButtonBase component from a class component to a function component.
Feel free to contribute other improvements to the component while refactoring if you notice any.
Refer to other components to keep formatting consistent. For example, reference the Badge, BadgeButton, or Tabs components.
How to Contribute
Please review the contributing documentation beforehand.
Steps to Contribute:
- Fork the repository.
- Clone it to your local system.
- Create a new branch.
- Make your changes. Make sure that tests are still passing. To update snapshot tests, run
npm run test -- -uand include the updated tests in your commit. - Commit your changes. When committing be sure to prefix with the appropriate conventional commit type. For example,
refactor: buttonbase component. - Push up your changes. In GitHub, click the compare & pull request button to begin drafting your pull request.
- Fill out the pull request form and attach the "ready to review" label when complete.
Hi @nataliepina, I would like to work on this issue, Can you assign it to me?
Done, thanks @Adw8!
Hi @Adw8 have you been able to start refactoring? Please let us know if you need any help with anything. Cheers!
Hello @nataliepina, I have been able to start, I'll keep you updated and let you know if I need any help, Thanks!
Hi @Adw8, are you able to get this into a pull request this week? We're happy to provide feedback there to get this across the finish line. Otherwise, we may start the refactoring of this next week.
Hi @nataliepina, Unfortunately, I will not be able to complete this issue, Kindly assign it to someone else, Apologies for the inconvenience!
No problem, thank you for the update.