d2iq/ui-kit

Migrate Table component tests from Enzyme to React Testing Library

Closed this issue · 4 comments

nataliepina commented

Description

This issue is related to refactoring the tablev2.test.tsx test file.

We've recently been migrating our tests from Jest + Enzyme to Jest + testing-library/react to support a full migration to React 18.

You may refer to this previous PR beginning the migration for code examples - #771.

Acceptance Criteria

Refactor the test to use React Testing Library instead of Enzyme (which is no longer supported with React 18).

More information: Migrate from Enzyme

How to Contribute

Please review the contributing documentation beforehand.

Steps to Contribute:

  1. Fork the repository.
  2. Clone it to your local system.
  3. Create a new branch.
  4. Make your changes. Make sure that tests are still passing. To update snapshot tests, run npm run test -- -u and include the updated tests in your commit.
  5. Commit your changes. When committing prefix your commit message with the appropriate conventional commit type. For example, refactor: <component_name> tests.
  6. Push up your changes. In GitHub, click the compare & pull request button to begin drafting your pull request.
  7. Fill out the pull request form and attach the "ready for review" label when complete.
manav-06 commented

hi @nataliepina , you can assign this to me

nataliepina commented

Assigning you @manav-06, thank you for contributing!

nataliepina commented

Hi @manav-06 how is the test migration coming along? Please let us know if you need any help, thanks!

manav-06 commented

@nataliepina please review #846 . Sorry for the delay. I was occupied with a college project

  • 👍1