Update to Webpack 5
Closed this issue · 11 comments
Description
We'd like to update from Webpack 4 to Webpack 5.
The new version of Storybook (7) is in alpha testing and set to release soon. With this new version, Webpack 5 will be suggested. Upgrading Webpack will allow for build optimizations, such as lazy compilation and filesystem caching.
There may be some caveats to this update alongside Storybook and some research to be done there to resolve any issue while updating.
More info: https://storybook.js.org/docs/react/builders/webpack#webpack-5
Acceptance Criteria
Update to Webpack 5
Clean up our existing Webpack setup. Can it be consolidated into 1 file instead of 2?
How to Contribute
Please review the contributing documentation beforehand.
Steps to Contribute:
- Fork the repository.
- Clone it to your local system.
- Create a new branch.
- Make your changes. Make sure that tests are still passing. To update snapshot tests, run
npm run test -- -uand include the updated tests in your commit. - Commit your changes. When committing prefix your commit message with the appropriate conventional commit type. For example,
refactor: <component_name> tests. - Push up your changes. In GitHub, click the compare & pull request button to begin drafting your pull request.
- Fill out the pull request form and attach the "ready for review" label when complete.
@nataliepina I can pick this up
Thanks @taksuparth let us know if you have any trouble.
@nataliepina I will be picking this up in the upcoming weekend.
Hey @taksuparth 😃 Are you in progress on this one yet?
Hi @nataliepina! I could not find time to pick this up yet. Give me 1 week's time, I will inform here if I won't be able to pick this up.
No problem at all @taksuparth, thanks!
Checking back in @taksuparth are you able to complete this one? It's blocking some other upgrades and will be a very important feature to improve ui-kit. Your contribution would be highly appreciated! Thanks.
@nataliepina I have started working on it but couldn't find a time stretch to finish every aspect of the task. Plus, I am traveling for the next 2 weeks, so I won't be able to pick it up. You can unassign me from this task as of now. Once I will be back and if it is not picked, I will finish it.
@taksuparth If you want and find the time you could create a work-in-progress PR so that we could use the work you've already done. No pressure if you are not able to do that!
I've unassigned you from that task.
Sure, I will share WIP PR in sometime
We can definitely work with your changes if you still have the availability to get that into a pull request sometime soon @taksuparth. Thanks!