d3/d3-array

Contribute bin2d

pbettler opened this issue · 5 comments

pbettler commented

Not sure how to contribute d3.bin2d, a 2d version of d3.bin. It comes with the tape test.
I could not find a contribute.md.
Should I fork the repo and do a PR?
Thanks.

curran commented

Typically the first step is to propose the feature: describe what it is and why it would be useful.

Then, evaluate how difficult it would be to do outside the library (provide some sample code).

Then, if it makes sense to add it to the library, fork the repo and do a PR.

Or, if you already have made the changes, submit a WIP (work in progress) PR for evaluation, just to provide visibility into the work you've done so far (for example, call it something like "WIP bin2d").

pbettler commented

Thank you @curran, I just created the PR for bin2d

pbettler commented

@curran Is there a timeline for the review?

curran commented

Just reviewed. Nice work! See my review comments here #101

Fil commented

Closing due to inactivity (see #101 (comment)). Please don't hesitate to comment/reopen.