d3/d3-brush

Handle orphaned gestures.

mblandfo opened this issue · 4 comments

mblandfo commented

Reproduction: https://jsfiddle.net/njjd40vj/1/ (modified from http://bl.ocks.org/mbostock/b0d0aa4df3b5c3c0fa37d4b3f2127740 just to log start/end events)

IE 11:

  1. open console, brush a bit, notice "start" and "end" brush events get logged
  2. mouse down, mouse off browser,
  3. mouse up. start is logged, but end is not
  4. mouse back on browser, try to keep brushing. start and end events no longer get logged.

Chrome:

Change 3) to be
3) mouse over another window. right click (left button is still down). end is not logged and start/end events no longer fire

mblandfo commented

This was on Windows 7. It does not appear to reproduce on Mac Chrome.

mbostock commented

Hmm. Not sure if I’m going to be able to do much with this. I can use VirtualPC to test Windows, but I don’t have a lot of resources to debug platform-specific issues and often rely on contributors for fixes.

If the mouseup is not received by the window, then the brush will still consider the gesture active. Per brush.js, only the start of the first active gesture will trigger a start event, and only the end of the last active gesture will trigger an end event. So it’s totally plausible that if the browser fails to dispatch the mouseup event, that you never see subsequent start and end events (on that specific element), because it still considers the earlier gesture to be active.

It sounds like the browser isn’t dispatching the mouseup event because it’s outside the window. Unfortunately this behavior isn’t standardized (see d3/d3-drag#9), so we’re all waiting for element.setPointerCapture to capture events reliably. An alternative might be to deem certain input events as terminating any active gestures and starting a new gesture: a mouseup event, or a touchstart event where event.changedTouches.length === event.touches.length. But that assumes that a mouse and touch can’t be active simultaneously, which isn’t true of all devices.

mblandfo commented

Perhaps it could be an option passed in to make mousedown terminate a gesture and start a new one. Maybe default to this. Or - if there are no active touches and you get a mousedown, that should terminate and start anew.

I'm not familiar with all the use cases here so I'm just asking: on some devices you can touch and mouse, but why would you want to do them both at once to use the brush? Multiple touches with no mouse makes sense I think.

mbostock commented

An alternative might be to deem certain input events as terminating any active gestures and starting a new gesture: a mouseup event, or a touchstart event where event.changedTouches.length === event.touches.length.

I did this.