d3lm/ngx-drag-to-select

When dts container is destroyed, items are unselected

Eagleseb opened this issue · 2 comments

Eagleseb commented

Hey,

Because in the complete

ngx-drag-to-select/projects/ngx-drag-to-select/src/lib/select-container.component.ts

Line 318 in 75a05d4

this.selectedItemsChange.emit([]);
an empty array is emitted, elements are always unselected when dts container is destroyed.

This is annoying if selected items list is shared with other components.

I suggest to not emit an empty array if there are not any good reasons for that.

Best,
Sébastien

Eagleseb commented

Actually I noticed that the select Output does just that already. You may close my issue and reject my PR :)
sorry for the trouble

d3lm commented

Oh no worries, glad you figured it out. Thanks!