Remove unused checks

Question

Remove unused checks

ryanbr opened this issue 3 years ago · 4 comments

Just a review of the current toolz checks. When adding domains, are there example sites being used to reference against each check? Seems pointless adding a domain check if it's never used outside of https://d3ward.github.io/toolz/adblock.html

A few checks aren't actually used for tracking, people may link to these Twitter pages for example, but they're not tracking or ads.

https://blog.twitter.com/advertising
https://blog.twitter.com/marketing/en_us.html
https://blog.twitter.com/
https://advertising.twitter.com/

https://an.facebook.com/ shows no sites using it for tracking, no network blocks

The actual domain for fastclick.com is fastclick.net, fastclick.com isn't a legit ads/tracking domain. Checking the .net is all is needed.

Answer 1 · 2022-06-03T00:14:14.000Z

Hello @d3ward.. Just curious if any of these suggestions by @ryanbr are to be considered for future updates.. I know it's in Beta stages.. Would love to see the whole thing succeed.

Answer 2 · 2022-06-03T01:35:55.000Z

@RicoHeat Regarding adding these to Easylist or Easyprivacy. No. Adding domains that aren't actually used seems to be pointless. The benchmark should always be checking valid domains used on websites.

Until these invalid domains are removed, just avoid this "benchmark".

Answer 3 · 2022-06-03T07:46:36.000Z

Yes @RicoHeat , the changes will be included in V3 directly as stable . Still working on it since i want to make it almost perfect ! I think everyone will love it even more than current

Answer 4 · 2023-02-04T10:26:39.000Z

Domains removed on upcoming version 3.0.0 of toolz