d4l-data4life/kirby3-static-site-generator

Problems with virtual translated pages

Sunnyka98 opened this issue · 1 comments

Expected Behavior

I use the static site generater and this plugin to generate a xml feed.

I expect that the static site generater also translate virtual xml pages.

Current Behavior

At the version 1.12.0 of the static site generater the xml page is not translatet, so the default language is used.

Possible Solution

Possible the error is on line 215, there the _setPageLanguage - funktion checked if the page is exist. Without the condition in line 227 everything worked.

Steps to Reproduce

I get a plain kit from kirby. Add some pages, the feed plugin from bnomei and the static site generator.
I made a little repo to show the error.
If you run the generator.php, an look than in the build folder to the feed-en.xml the title and the description of the single pages are on the default language german.

Context

I use the kirby version 3.9.6, version 1.12 from the static-site-generater on Windows and the plugin is manually installed as submodule. I trigger the static site generator manually via script.

@Sunnyka98 thanks a lot for reporting this bug and providing the repo for reproducing it 🙌
Release 1.12.1 should solve your issue. Let me know if something else is broken, thanks!