dalance/amber

Broken replace with symlink

Closed this issue · 2 comments

If we have a symlink, e.g.

1. A/a.txt
2. A-symlink/a.txt

then ambr replaces 1 and then wrongly replaces 2.

ambr 'nazel_package()' 'package(default_visibility = ["//visibility:public"])'

Replace keyword? [Y]es/[n]o/[a]ll/[q]uit: y
./A/a.txt: nazel_package()
        -> package(default_visibility = ["//visibility:public"])
Replace keyword? [Y]es/[n]o/[a]ll/[q]uit: y
./A-symlink/a.txt: package(default_visibility = ["//visibility:public"])
                -> package(default_visibility = ["//visibility:public"])_visibility = ["//visibility:public"])

Thanks! I've fixed it.

elbaro commented

I don't work on the codebase in the issue anymore. Feel free to close if you tested the fix.