.Net Standard 2.0 compiler errors
Closed this issue · 13 comments
With the latest LibLog from either master or the netstandard branch, attempting to compile a .Net standard 2.0 library fails, due to the use of "dynamic".
Error CS0656 Missing compiler required member 'Microsoft.CSharp.RuntimeBinder.Binder.Convert' ClassLibrary1 ClassLibrary1\Class1.cs 561 Active
One piece of code with issue:
private static dynamic s_currentLogProvider;
internal static ILogProvider CurrentLogProvider => s_currentLogProvider;As stated by the author, you need to manually add the LibLog.cs file for a .NET Standard library projects.
Since NuGet is not used, you miss a reference to Microsoft.CSharp assemply, which guess what, is providing dynamic support in .NET Standard.
By manually adding that NuGet package, everything works fine 😄
Okay, that makes sense. We are producing a library that has no external dependencies, so unfortunately, adding the reference adds another dll to the output, instead of simply our library.
I'm producing a .NET Standard 2 library too, and I found if you set the consuming application Net Framework version to newer ones (if it is possible, like 4.7.2) you get way less dependancies (windows related)
For example I was using 4.5 and had tons of dependancies dlls in output folder, now with 4.7.2 I have zero, besides the library.
What I suggested before is a "dirty" fix let's say, if you can live with some added dlls is fine, or you can consider using a newer framework version for the consuming application.
Maybe LibLog devs will take care of this issue with an update
Fixed on master via #149. v5.0.0 that works with SDK projects should be available in the coming weeks.
It seems as though LibLog bringing in Microsoft.CSharp as a transitive dependency is not enough. I have to install Microsoft.CSharp directly into the project and only then does it work.
Really? Hmm... will investigate
Weird, I had to include it as a direct dependency also.
LibLog is declaring dependency on Microsoft.CSharp 4.4.0, but that gives the following error:
CS0656 Missing compiler required member 'Microsoft.CSharp.RuntimeBinder.Binder.Convert'
I've had to depend on Microsoft.CSharp 4.5.0 for to correct this, so it seems that LibLog should depend on 4.5.0.
Doing a direct dependency on 4.4.0 also works so I don't think the difference in version is the issue
Correct, it seems to be just about having a direct dependency.
One suggestion here, if you dont use dynamic and use object instead it will work. Since Reflection on public methods works fine even in medium trust environments that would work to bring back the dynamic parts.
It feels icky but when faced with challenges like I have with a CMS SaaS where I dont even control the compiler used... hehe
I might have to submit a PR here too
A PR to replace dynamic with object and we can get rid of that dependency would be appreciated.