Verify that hybrid pulse and pulse2 waveforms do what they should
Closed this issue · 1 comments
danfrz commented
When I wrote some of them I wasn't really focussed on making them work perfectly, I was mostly focussing on perfecting Pulse1. Pulse2 and Hybrid were afterthoughts so their output should be verified.
Confirmed not working:
- 08 - Pulse Saw (only has down-trough). Fixed
- 0C / 0D Not really implemented, substitute with something else later
-
0E06 - Square Pulse2(REALLY Broken). Fixed - 0F - Square Pulse Hybrid (Doesn't work because 0E doesn't). Fixed
- 14 -
Triangle Pulse 2(doesn't work as intended; is identical to 07). Removed - 15 -
Triangle Pulse Hybrid(Doesn't work because 14 doesn't). Removed - 16 - Sine Pulse 2 (doesn't work as intended; is identical to 09). Fixed
- 17 - Sine Pulse Hybrid (Doesn't work because 16 doesn't). Fixed
- 18 - Half-Sine (broken, keeps resetting phase mid-waveform). Fixed
- 1A - N Sine W (broken, keeps resetting phase mid-waveform Only when wave param > 1). Fixed
- 1C N Sine Pulse 2 (doesn't work as intended; is identical to 1B). Fixed
- 1D N Sine Pulse Hybrid (Doesn't work because 1C doesn't). Fixed
- 1E N Half-Sine (broken, keeps resetting phase mid-waveform)
danfrz commented
All of these waveforms have been fixed! (or removed)
Triangle Pulse 2 and Pulse Hybrid have been removed because how you would need to implement them would be very strange and require more work than it's worth.