danger/kotlin

Release 1.0.0

f-meloni opened this issue · 12 comments

f-meloni commented

Roadmap to 1.0.0:

  • Make danger-kotlin work with gradle 5.0 (@gianluz is already working on it)
  • Decide what use to distribute danger-kotlin (maybe brew for Mac, but what for Linux?)
  • Change the name of the generated library (no snapshot) (I think @gianluz has some ideas for this)
  • Write documentation
  • Support for Dangerfile path from cliArgs (danger-swift implementation
    #100)
  • Getting Started Tutorial
  • Make a plugin
  • Usage guides
  • Create files on the json files on the tmp folder instead of the current folder
  • Find a way to allow custom GitHub API calls
orta commented

Once there are stubs for docs and stuff, I'll come and help out with the 1.0ing too (specifically around docs, on boarding etc) 👍

f-meloni commented

@orta Nice! Thank you :)

gianluz commented

opened a PR for the library version name!

  • 🚀1
gianluz commented

update for gradle 5.0: kscript works with the gradle-capsule-plugin that is not maintained anymore, i forked the plugin, and i have uploaded the new plugin on the plugin portal, now is awaiting for approval, when approved i need to open a PR on kscript using the new capsule plugin.

kscripting/kscript#197

f-meloni commented

Now that brew has official support for Linux too, it could be the right decision to distribute danger-kotlin with it :)

orta commented

( as ever, be careful of Homebrew as the main installation route for any dev tools http://artsy.github.io/blog/2019/01/05/its-time-to-use-spm/#What.are.the.downsides.of.the.status.quo )

f-meloni commented

@orta thanks for the interesting article!
Yes homebrew has the problem of the versioning (installing the tool globally i think would be ok in this case).
My idea was to obviously add different ways to install it, but I don't know what else would be a good option.
We have as dependencies kscript, kotlin, maven, danger-js and gradle, and they are all in brew, this is why I would start from there to have one single command option to install the tool.
And also it allows us to build danger-kt directly on the destination machine (that is what we need because we can not generate single bin for all the platforms)
But would be cool to have another way of installing it, a versioned one! Do you have any suggestions?

  • 👍1
cesards commented

Guys, is this release up to date?

I'm really looking forward to using Danger at my company and I was thinking about contributing as much as I can. There are no "feature-related" issues and the release milestone seems to be updated. How could I help?

@f-meloni @gianluz

  • 👍1
f-meloni commented

I think #60 is the real blocker for a 1.0.0 (and a lot of docs :D)

  • 👍1
gianluz commented

#60 merged

orta commented

It's 2021, is it time to 1.0? 🍡

  • 👍1
f-meloni commented

With 1.0.0-beta2 we should be really close to a final release 🎉