Notifications When I Send a Message

Question

Notifications When I Send a Message

Closed this issue 7 years ago · 34 comments

I get a notification in notification center whenever I send a message. It contains text from the message I just sent. It looks just like a notification when I get a message, but it's my own words right after I hit send. Is this supposed to happen? It seems kinda weird. (And sorry if this issue has already been reported, my search of other issues was pretty quick.)

ryndshn commented 7 years ago

+1

unremarkablegarden commented 7 years ago

Me too

jrozelle commented 7 years ago

Same here

MikaelStrom commented 7 years ago

Same here

Wemps commented 7 years ago

💸

Answer 1 · 2017-07-12T12:42:56.000Z

Same problem here.

Answer 2 · 2017-08-11T23:38:22.000Z

Facebook messenger itself has been doing this to me. It may be on their side.

Answer 3 · 2017-08-28T14:32:42.000Z

Version 3.2.2 (2001)

Quitting and restarting Goofy.app made the bug unreproducible.

Answer 4 · 2017-12-14T19:00:12.000Z

Looks like the bug is still present in version 3.2.2

I systematically get notifications for messages I send

Answer 5 · 2017-12-14T21:38:29.000Z

I'm seeing this behavior in 3.2.2 as well.

Answer 6 · 2017-12-27T14:16:30.000Z

Same here (v. 3.2.2)

Answer 7 · 2018-01-01T23:58:49.000Z

Also getting this on 3.2.2

Answer 8 · 2018-01-03T19:32:26.000Z

I am as well. It comes and goes but is pretty consistent. Maybe one of us smart folks should do something about it :p

Answer 9 · 2018-01-05T16:27:45.000Z

Adding more comments like same here etc. won't fix this issue. Posting this comment you only notify subscribed people about, well, nothing.

I am waiting for resolution or relevant information and the only thing I get via notifications are those comments :( And I do not want to unsubscribe because I want to be notified on resolution :)

Answer 10 · 2018-01-12T23:20:14.000Z

Adding a $10 bounty for this bug. Fix it and I will Venmo you money. I cannot stand this. v3.2.2

Answer 11 · 2018-02-11T21:32:10.000Z

Hey @Wemps fell free to send that sweet bug bounty to my Venmo: https://venmo.com/gartz

btw, the bug was annoying me too, hope they merge and release it soon if not, you can clone the project and run locally in that meanwhile.

PR with the fix: danielbuechele/goofy-core#11

Answer 12 · 2018-02-12T18:18:35.000Z

A quick tutorial how to use the fork with the patch:

git clone --recursive https://github.com/gartz/goofy.git
cd goofy
npm install
NODE_ENV=production npm run build-mac

You can replace the build-mac by build-win if you're in a windows machine.

After that you will have your binary file inside the dist folder. It will show an signature failure alert when you start, because you build it without using the author app signature, but that is fine. The app will run fine with the bug fixed.

My master branch also includes a performance issue fix.

Then let's hope that @danielbuechele like the patch and have time to release the patch to everybody :)

Answer 13 · 2018-02-12T23:28:52.000Z

this should be fixed in version 3.3.0 that was just released

Answer 14 · 2018-02-13T12:29:37.000Z

Not fixed. Still the same issue.

Answer 15 · 2018-02-13T12:30:33.000Z

i also experienced this issue last night, after updating

Answer 16 · 2018-02-13T12:32:06.000Z

What language are you using messenger in?
To detect if it's a message sent from you, I am checking if the preview text in the sidebar is prefixed with "You:"

Answer 17 · 2018-02-13T12:33:25.000Z

@danielbuechele English. OS X 10.12.6

Answer 18 · 2018-02-13T12:33:59.000Z

i’m using it in english. i believe it occurred when sharing a facebook post in a private message (from facebook).

Answer 19 · 2018-02-13T12:38:41.000Z

Ok, can you confirm this is happening for every message you send? As I said, I am checking for the exact string in the message preview in the sidebar. If it starts with "You:" the notification should not be sent. But for example if it starts with "You sent a photo" (missing the colon) the notification is still sent.
Can you confirm this happens just for plain messages as well?

Answer 20 · 2018-02-13T17:07:39.000Z

It occurs with "You sent a link."

Answer 21 · 2018-02-13T17:09:05.000Z

Ok, does anyone have an idea how we can fix this? I mean, we can look for lines starting with "You", but when someone writes you a message "You are awesome" you won't get a notification.

Answer 22 · 2018-02-13T17:29:59.000Z

It really depends on how Facebook messenger itself is doing it. If a simple property like "profile_id" could be obtained from any of these elements, this would be such an easy fix. But the way the previous dev wrote the check was by using a now-useless translation tag-- never a good idea because of how often Facebook changes these things. We can try to think of good-enough fixes, but they will change too and we'll be right back here.

The only good-programming fix is the one facebook uses itself-- especially because we're not even using their API anymore. I spent a good few hours trying to fix this myself, and while the place where it's broken is obvious, a replacement for that if statement is not so obvious.

Daniel-- do you still work with/at Facebook? Any insight on their methodology here? It can't be as simple as a string comparison like "You:", can it? If we had some kind of unique identifier element between the sender and receiver (like profile_id), this could be fixed forever.

Answer 23 · 2018-02-13T18:47:20.000Z

The fix works, sadly the merge for version 3.3.0 reverted my patch.

If you checkout the commit 51612d3773ac3920c69e0850626d912cac277347 and run locally will see that it works.

Answer 24 · 2018-02-13T18:48:03.000Z

Sorry for messing up the merge, could you send another PR?

Answer 25 · 2018-02-13T18:48:55.000Z

I will, was very busy lately and could not fix it. I will send in a few minutes

Answer 26 · 2018-02-13T19:15:45.000Z

Hope this helps again, there it is the patch again, it works in any language. :)

Answer 27 · 2018-02-16T15:41:53.000Z

@gartz as soon as I get the update you got the money (will either build it myself when I get back this weekend or wait for next release)! Thanks for taking the time to address this!

Answer 28 · 2018-02-16T15:46:14.000Z

I'll create an update 3.3.1 right now so @gartz get's his well deserved money! Thanks for helping!

Answer 29 · 2018-02-20T16:54:16.000Z

@Wemps and @danielbuechele you guys are awesome, remind me why I choose to programme as my career. I'm very happy to contribute here, and thankful for @danielbuechele project.