danipen/TextMateSharp

Use [Flags] enum for FontStyle

Closed this issue · 3 comments

Khitiara commented

TextMateSharp.Themes.FontStyle is currently a class with int fields representing a bitfield. This sort of bitfield is normally represented in c#/dotnet as an enum with the [Flags] attribute, so FontStyle should be updated to match.

danipen commented

Agree. The implementation is a port from tm4e so it matches that implementation. But there are some areas for improvement.

@Khitiara would you like to add a PR for this?

Khitiara commented

ill fork it and do it, this should be a relatively quick thing

  • 👍1
danipen commented

Merged! Thanks for the contribution.