danmarsden/moodle-mod_attendance

Bulk mark links don't work on Moodle 4.3

Closed this issue · 6 comments

ehoving commented

The links to bulk mark attendance are not working on Moodle 4.3

Can this be fixed?

attendance bug

danmarsden commented

Thanks for the report - if you have internal development capabilities, feel free to help further by submitting a pull request with the fix!

danmarsden commented

looks like this is being picked up in the behat tests on the new 4.3 branch too which is helpful.

aspark21 commented

might be that re-grunting against 4.3 might clear that up @opitz ?

danmarsden commented

I would have expected the moodlecheck call to trigger a warning if grunt was stale - but I've run it just in case locally on a 4.3 site and it doesn't trigger anything - I'd expect there's some other javascript conflict somewhere.

opitz commented

@danmarsden Apologies! I have a typo in my fix when I replaced deprecated JS function M.util.set_user_preference().
Will provide a PR ASAP.

danmarsden commented

thanks @opitz - I missed that too! :-)