danofthewired/puppet-bitbucket

init script status check fails on EL6

Closed this issue · 3 comments

joshbeard commented

https://github.com/danofthewired/puppet-bitbucket/blob/master/templates/bitbucket.initscript.redhat.erb#L76:

STATUS=$( ps aux | grep "[c]atalina.base=$CATALINA_HOME" | wc -l )

It appears BitBucket >= 5.0, that string is no longer matched in the process table, at least not on the EL6 systems that I've tested on.

I'm not sure if that the catalina.base should be in the command for BitBucket, but it's not here.

Is something like:

STATUS=$( ps aux | grep "com.atlassian.bitbucket.internal.launcher.BitbucketServerLauncher" | wc -l )

An acceptable replacement? I'd be happy to submit a pull request to update the string to match on.

joshbeard commented

Disregard the com.atlassian.bitbucket.internal.launcher.BitbucketServerLauncher string, that doesn't seem to apply to 4.x

joshbeard commented

PR #45 is a proposed fix

joshbeard commented

#45 was merged, resolving this.