danopstech/starlink_exporter

Throughput Unit

willshen opened this issue · 0 comments

Describe the bug
starlink_dish_uplink_throughput_bytes and starlink_dish_downlink_throughput_bytes are calling API that returns unit in bits

Expected behavior
If we want to keep the same metric names, starlink_dish_uplink_throughput_bytes and starlink_dish_downlink_throughput_bytes, we probably should divide the return values from API by 8. Otherwise, we should consider renaming them to starlink_dish_uplink_throughput_bits and starlink_dish_downlink_throughput_bits