Exclamation mark isn't tags as a sent-final punct

Question

NickZambrano opened this issue 7 years ago · 3 comments

In the readme it says that the "!" should be tags as a sent-final punct (".")

In fact on my side it's tagged as "!" so if I console.log I got ["!","!"] and not ["!","."].

Answer 1 · 2018-04-10T11:21:08.000Z

I think the problem is caused by the lexicon in lexicon.js. It assigns ! to !:

 "!": [
        "!"
    ],

If you change this to . it should work correctly.

Hugo

Answer 2 · 2018-04-10T12:33:49.000Z

After looking in the code, I saw, but maybe the readme should be updated, right ?

Answer 3 · 2018-04-10T12:50:35.000Z

I think the lexicon should be updated according to the README. The tags as defined in the README follow PENN Treebank tags.

Hugo