dart-lang/dart-syntax-highlight

Add documentation telling folks who update this to update github/linguist

Closed this issue · 8 comments

kevmoo commented

Should follow-along to update the submodule as changed in github-linguist/linguist@96ca71a

CC @mit-mit

devoncarew commented

I don't think the linguist submodule reference to here is pegged to a specific commit? They should just get the updated bits periodically?

kevmoo commented

I don't think the linguist submodule reference to here is pegged to a specific commit? They should just get the updated bits periodically?

It seems these are updated manually 🤷‍♂
https://github.com/github/linguist/commits/master/vendor/grammars

kevmoo commented

...git submodules are always landed at a specific commit.

devoncarew commented

...git submodules are always landed at a specific commit.

Ah, gotcha. Then updating the instructions for rolling out changes to the downstream users makes sense.

mit-mit commented

I don't think this is needed; my understanding is that the GitHub maintainers update all submodules prior to releasing:

https://github.com/github/linguist/blob/master/CONTRIBUTING.md#releasing

  • 👍1
kevmoo commented
devoncarew commented

I don't think we have any action items here -