dart-lang/sdk

dartc build failure: private DartNode.setParent()

DartBot opened this issue · 7 comments

This issue was originally filed by waqne...@gmail.com


What steps will reproduce the problem?

  1. build dart compiler

What is the expected output? What do you see instead?
dart/compiler/java/com/google/dart/compiler/ast/DartNode.java fails to compile with the following error:
    [javac] /data/down/devel/dart/dart/compiler/java/com/google/dart/compiler/ast/DartNode.java:122: error: setParent(DartNode) has private access in DartNode
    [javac] child.setParent(this);
    [javac] ^

What version of the product are you using? On what operating system?
dart svn, javac 1.7.0 on arch linux

Please provide any additional information below.
Making setParent() protected instead of private fixes the issue for me, allowing it to be called from protected method becomeParentOf() of the same class.

Added Area-Compiler label.

This comment was originally written by drfibonacci@google.com


Set owner to mmend...@google.com.

This comment was originally written by drfibonacci@google.com


Added Accepted label.

This comment was originally written by remi.forax...@gmail.com


the correct way to fix it is to write:
  ((DartNode)child).setParent(this);

It's avoid to change the visibility of setParent.

This comment was originally written by johnle...@google.com


Should be fixed at r471


Set owner to johnle...@google.com.

This comment was originally written by waqner...@gmail.com


The fix works for me.

This comment was originally written by johnle...@google.com


Added Fixed label.