dart-lang/setup-dart

Migrate v1 tag to point to v1.2

timsneath opened this issue · 4 comments

timsneath commented

As I understand it, the v1 (not v1.0) tag should always point to the Git ref of the current minor release, per https://docs.github.com/en/actions/creating-actions/about-actions#using-tags-for-release-management

This enables users to tag dart-lang/setup-dart@v1 and get the latest bug fixes.

The idea is that users can both pin to a specific version (by tagging dart-lang/setup-dart@v1.0 in their workflow) or pin to a major version only. Right now, v1 still points to v1.0.

mit-mit commented

Fixed:

$ git log --pretty=oneline
ade92c2f32c026078e6297a030ec6b7933f71950 (HEAD -> main, tag: v1.2, tag: v1, origin/main, origin/HEAD) Prepare for v1.2 release (#41)
f2efe02090c00e6a5b569b3f29f6ffcb21f9e0dc Fix a typo in a user facing message (#40)
989c0944670219a1c5db6cc72258d5d369fc0c0b Fix pub cache issue in Windows (#39)
e431f4b9d8387dfea7bda4aa522b6382d0f41701 add a "dart test" test (#38)
fa07b23c84e2bdb044d78cb24e69cb6ba73a82ae (tag: v1.1) Add a way to setup raw builds for all channels (#36)

And documented for prosperity:
https://github.com/dart-lang/setup-dart/wiki/Publishing-procedure

timsneath commented

Looks like this might not have worked, I'm afraid. Right now, the v1 tag still seems to point to the v1.0 hash.

$ git ls-remote --tags git@github.com:dart-lang/setup-dart.git | grep v1
57198e889390e8e71394826d8cb99056ec62bae3        refs/tags/v1
9a04e6d73cca37bd455e0608d7e5092f881fd603        refs/tags/v1^{}
63bf62f8d36031fe2755e5fd6356ded42fb99d73        refs/tags/v1.0
9a04e6d73cca37bd455e0608d7e5092f881fd603        refs/tags/v1.0^{}
fa07b23c84e2bdb044d78cb24e69cb6ba73a82ae        refs/tags/v1.1
ade92c2f32c026078e6297a030ec6b7933f71950        refs/tags/v1.2
6a218f2413a3e78e9087f638a238f6b40893203d        refs/tags/v1.3
mit-mit commented

Hmm, I'm a tags noob. Can you check again; I believe it's fixed now?

timsneath commented

Ah yes -- this looks right now.

git ls-remote --tags git@github.com:dart-lang/setup-dart.git | grep v1
6a218f2413a3e78e9087f638a238f6b40893203d        refs/tags/v1
63bf62f8d36031fe2755e5fd6356ded42fb99d73        refs/tags/v1.0
9a04e6d73cca37bd455e0608d7e5092f881fd603        refs/tags/v1.0^{}
fa07b23c84e2bdb044d78cb24e69cb6ba73a82ae        refs/tags/v1.1
ade92c2f32c026078e6297a030ec6b7933f71950        refs/tags/v1.2
6a218f2413a3e78e9087f638a238f6b40893203d        refs/tags/v1.3

and I can see the new version is being picked up:

Installing Dart SDK version "latest" from the main channel (raw) on linux-x64

versus (old, pre-flavors)

Installing Dart SDK version "latest" from the main channel on linux-x64

Thanks!

  • 👍1