dart-lang/webdev

Update wildcard handling in tests for proper debugging behavior

Opened this issue · 1 comments

jyameo commented

Description:
Currently, the wildcard variable in the test is handled inconsistently between the library bundle format and the AMD module format. The CFE now renames wildcards to temporary variables as multiple wildcards can exist.

Library bundle format: Correctly excludes the wildcard variable from debugging.
AMD module format: Emits _ instead of a temporary name.

Per the discussion with DDC folks, it was agreed that wildcard variables are not expected to be available via debugging. Therefore, the library bundle format's behavior is correct, while the AMD format's behavior might not be.

srujzs commented

Thanks for filing!

while the AMD format's behavior might not be

might is a good qualifier. It's undefined behavior on what a wildcard's JS name should be. Because of that, _ is a totally valid JS name as long as it doesn't conflict, but it'll require a bit more testing to determine if it's doing something erroneous.

  • 👍1