darwinia-network/darwinia

Review places that create reserved in balance, and why it is not counted in reducible_balance

hackfisher opened this issue · 5 comments

          https://github.com/paritytech/polkadot-sdk/blob/ffbce2a817ec2e7c8b7ce49f7ed6794584f19667/substrate/frame/balances/src/impl_fungible.rs#L47-L72
image

0xC1c8F6Ef43b39C279417E361969d535F2a20b92e

https://github.com/darwinia-network/frontier/blob/9c50b611ce93033cf2766281c8c38c73757ec502/frame/evm/src/lib.rs#L897

Originally posted by @hackfisher in #1483 (comment)

Another report from @1022ranji 0xe59261f6D4088BcD69985A3D369Ff14cC54EF1E5

image

This causes metamask show usable balance but no able to pay gas.

Related:

paritytech/polkadot-sdk#1833

paritytech/polkadot-sdk#2292

The substrate current using is inconsistency with the latest new definition in the referred issue.

image (5)

Fixed in the runtime 6630. Close it.