dashbitco/flow

Flow.from_specs and failed starts

isaacsanders opened this issue · 4 comments

Hey all!

I have been seeing an error that I think comes from Flow.from_specs. It assumes that the result of the start_link anonymous function is {:ok, pid()}, and when it is {:error, term()}, the output of the system is not easy to debug.

I can work on a PR for this, but I just wanted to put it here, if someone got to it first.

There is a discussion about how a failure should be handled, and I am personally of the opinion that it should fail on startup, but I understand that there might be different opinions on this.

We should fail to boot as it likely fails today but improve the error message.

Yeah, right now it is an exit, instead of a {:error, reason}.

Ping.

Hi @isaacsanders, do you still plan to submit a PR? Thanks.