dashjoin/platform

"Optional confirmation text" on Edit widget has no effect

Closed this issue · 3 comments

pgrill79 commented

The property "Optional confirmation text" has no effect on the Edit widget. The record is edited or deleted without the confirmation dialog appearing

aeberhart commented

should be adressed along with #349

aeberhart commented

The behavior currently is as follows:

  • all changes on the config DB are carried out immediately, without "undo" - the rationale for this is that changes to databases and functions are usually made right before the user expects to see a new DB table or run the changes function
  • drop table and drop column have a user confirmation
  • all other tables have "undoable" mutations
  • "bulk delete" from the table view is also "undoable" for all tables
  • the button widget handles the confirmation correctly - however, this can also be replaced with the confirm JSONata function
aeberhart commented

TODOs

  • remove deleteConfirmation from default templates
  • remove deleteConfirmation from the layout editor
  • keep it in dashjoin studio and switch edit mode to "pessimistic" if it is set
  • update documentation for edit.deleteConfirmation
  • also apply deleteConfirmation to table widget