color_locator() error? Chapter 6 p. 96
evohnave opened this issue · 7 comments
evohnave commented
recommend:
def color_locator(column, color_string):
return locate(color_string.upper(), column)
.cast("boolean")
.alias("is_" + color_string) # existing code has 'c' instead of 'color_string' - doesn't work
bllchmbrs commented
Could you please file this on the errata page?
https://www.oreilly.com/catalog/errata.csp?isbn=0636920034957
evohnave commented
O'Reilly's errata page is down... I went there first, then came here.
bllchmbrs commented
got it, mind just opening a PR with the change that you're proposing?
Glancing at it it looks like you're correct - just want to make sure we're
talking about the same thing.
…On Tue, Jul 10, 2018 at 1:30 PM evohnave ***@***.***> wrote:
O'Reilly's errata page is down... I went there first, then came here.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABkQBwqEjr2L9dMNaGRkOAoHi5NJR_0qks5uFQ7tgaJpZM4VJ_zQ>
.
--
Bill Chambers
Product Manager
<https://databricks.com/sparkaisummit/north-america>
evohnave commented
Will do... pretty sure I'm right... ran your code got errors, ran mine, no errors, correct output
bllchmbrs commented
that would suggest that you're right ;)
evohnave commented
OK, think I did that correctly... first PR... everyone's got to have a first, right?
bllchmbrs commented
Indeed! Nice work, thanks.