databricks/databricks-cli

Is the urllib3<2 pin necessary?

jtilly opened this issue · 4 comments

jtilly commented

Currently, urllib3 is pinned:

databricks-cli/setup.py

Line 45 in dd47ce4

'urllib3>=1.26.7,<2.0.0'

This happened in #637. Is this pin (still) necessary?

The PR description makes it sound like we needed this pin for requests. But requests should be fine with urllib3<3, see here.

This caused some hiccups on the conda packaging side (where the pin was missing), see conda-forge/databricks-cli-feedstock#23.

shreyas-goenka commented

@jtilly You are right, the upper bound can be increased to 3 here. I have created an issue for tracking this in our backlog. Please let us know if this is blocking and we can prioritize cutting a PR for this.

#645

mrmasterplan commented

+1 this breaks my pipeline. I would appreciate a fix.

jtilly commented

Please let us know if this is blocking and we can prioritize cutting a PR for this.

Thank you! Not blocking for me, but a PR would be appreciated 😉

mgyucht commented

This is addressed in #664.