databricks/databricks-vscode

[BUG] PATH delimiter bug `:` and `;`, running a powershell-terminal in vscode

erikrok opened this issue · 3 comments

Describe the bug
PATH delimiter bug, running a powershell-terminal in vscode.
After installing the extension, the PATH delimiter immediately after the path for the databricks extension is :, but the rest of the delimiters are ;.

Screenshots

c:\Users\username\.vscode\extensions\databricks.databricks-0.3.4-win32-x64\bin:C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\dotnet\;

System information:
Windows 10
VSCode
Powershell terminal
Databricks extension v0.3.4

Might be worth checking whether this context is aware of the OS path delimiter?

// Add the bricks binary to the PATH environment variable in terminals
context.environmentVariableCollection.persistent = true;
context.environmentVariableCollection.prepend(
"PATH",
`${context.asAbsolutePath("./bin")}:`
);

The notification when installing the extension is using a :
image

Hi @erikrok . Thanks for looking into the issue as well! This might be the cause. I will take a look at it.

Good catch!
This looks similar to golang/vscode-go#378
Their fix looks rather involved though hyangah/vscode-go@1b637ac