databricks/databricks-vscode

[BUG] Bash Terminal being overridden by databricks CLI within devcontainer

Closed this issue · 2 comments

asos-davidstafford commented

Describe the bug
When running running within a dev container using a linux (slim buster) docker image. Once built and opened within VS Code the bash terminal does not understand basic bash commands. the extension appear to have overridden it. probably related to this fix

image

To Reproduce
Steps to reproduce the behavior:

  1. DockerFile setting slim-buster image and installing AzureCLIDeb
  2. Create .devcontainer and include python and databricks extensions
  3. Open vscode within the dev container
  4. Awaiting it the build and try to run any bash command within the terminal .. eg 'ls'

Screenshots
If applicable, add screenshots to help explain your problem.

1.1.1 version of Environment Changes (Terminal environment contributions)
image

1.1.3 version
image

System information:

Version: 1.82.2 (system setup)
Commit: abd2f3db4bdb28f9e95536dfa84d8479f1eb312d
Date: 2023-09-14T05:55:25.390Z
Electron: 25.8.1
ElectronBuildId: 23779380
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22621

  1. 1.1.3 .. Issue appears to have come in 1.1.2

Databricks Extension Logs
N/A . doesn't get that far

Additional context
Add any other context about the problem here.

path going from

  • PATH=/root/.vscode-server/extensions/databricks.databricks-1.1.1-linux-x64/bin:${env:PATH}
    to
  • PATH=${env:PATH}/root/.vscode-server/extensions/databricks.databricks-1.1.2-linux-x64/bin:
    appears to be the problem

I believe the fix is putting the : after ${env:PATH}
ie. .. should be PATH=${env:PATH}:/root/.vscode-server/extensions/databricks.databricks-1.1.2-linux-x64/bin

asos-davidstafford commented

issue occurred on Line 91 - 94 on the extension.ts file. When changing from prepend to append, the delimiter was not moved to the front and was left hanging at the end. Therefore resulting in a squashed path between the last two items

kartikgupta-db commented

Aah. Thanks for reporting this issue @asos-davidstafford. Will fix it in the next release (Thursday). Sorry for the inconvenience. Please feel free to downgrade to unblock.

  • 👍1