datacarpentry/datacarpentry.github.io

Menu items in top menu bar does not display correctly

chendaniely opened this issue · 7 comments

I'm running Firefox 84.0.1 (64-bit) on Manjaro Linux using KDE
and the top menu bar for the data carpentry website does not toggle the navbar correctly as the browser window resizes horizontally.
This only happens on the DC website, not the SWC or LC websites.

when it's "narrow" (< 1027 pixels) the navbar correctly turns into the "hamburger" bar,
image

However, between 1027 - 1217 (inclusive) the "Home" to "For Instructors" options disappear, only showing "Sponsors, Contact, Search".
edit: It actually does not disappear, the "Home" to "For Instructors" actually show on a second line that gets covered up by the banner photo.
image

pixels >= 1218 wide it displays correctly.
image

Thanks for catching this @chendaniely
We'll look into updating the theme this website uses to see if that fixes things.

the problem comes from the fact that the template wasn't designed to include something other than "contact" and "search" on the right corner. By adding "sponsors", the responsiveness gets broken.

Thanks for catching the problem @fmichonneau

@serahrono do you have suggestions from a communications perspective of how to handle this? We could keep it as is, or we could remove the "sponsors" option. What do you think? I appreciate your feedback!

Pinging @serahrono

OK, I just tried to remove the "Sponsor" item from the right side of the tool bar and still get the same effect.
@fmichonneau do you have any other suggestions as to what might cause this?

dc_menubar

Ran into this issue myself today. Thanks @chendaniely for your excellent issue description! Mine wasn't going to be nearly as descriptive.

Closing this as we have reduced our menu layout and are planning additional changes so this will become irrelevant. Anyone can feel free to re-open or start a new issue if any other problems are revealed.