datacarpentry/r-intro-geospatial

Episode 3 Data Structures: Adjust Challenge 3 for factors/strings

cengel opened this issue · 5 comments

cengel commented

Challenge 3 still assumes that the default setting for read.csv is stringsAsFactors = TRUE.

r-intro-geospatial/_episodes_rmd/03-data-structures-part1.Rmd

Line 354 in 3ae8234

> ## Challenge 3

angela-li commented

Bumping this as we came across it in a recent workshop. I may have students do the opposite - reading in data and setting stringsAsFactors = TRUE even though the new default is FALSE

angela-li commented

Looks like #110 updates this and could be incorporated!

jsta commented

Have you reviewed #110 and it looks good to you @angela-li? If so, I'll go ahead and merge with your second opinion in-hand.

It looks good to me, but I haven't verified that it's all accurate.

  • 👍1
angela-li commented

Yes, you can merge it! There are many places in this curriculum that need to be updated to reflect default stringsAsFactors = F default as well, I can look through the open issues/PRs

  • 🎉1
angela-li commented

Since this was merged in a55e98e, I think we can close this issue as well @jsta?

  • 👍1