datacontract/datacontract-cli

Breaking method is not working with bigint columns

teoria opened this issue · 7 comments

teoria commented

When you compare 2 contracts with bigint and long column must be equal.


datacontract breaking  contract_v1.yaml contract_v2_glue.yml

1 breaking changes: 1 error, 0 warning
error   [field_type_updated] at contract_v2_glue.yml
        in my_table.fields.my_column.type
            changed from `bigint` to `long`
roykoand commented

@teoria I don't think that AWS Glue supports long data type. I've only seen bigint data type in their UI once tried to create a table:
image

image
teoria commented

@roykoand when i use the glue importer the code cast bigint to long
then when i call breaking the cli identify the type update.
the breaking method need ignore bigint->long or the import need keep bigint type

roykoand commented

@teoria yes, I agree. Data contract should keep bigint data type. This line is a culprit:

datacontract-cli/datacontract/imports/glue_importer.py

Line 268 in 56f4dbe

if sql_type.startswith("long") or sql_type.startswith("bigint"):

  • 👍1
teoria commented

or breaking ignore the bigint->long
@jochenchrist what do you think ?

jochenchrist commented

lets change the importer to keep bigint

jochenchrist commented

fixed with #351.

jochenchrist commented

Will be part of release v0.10.12

  • 🚀1