Support UUID x Text comparison

Question

Support UUID x Text comparison

MattDelac opened this issue 3 years ago · 11 comments

Describe the bug
Matt Delac 6:38 PM
Hi
@Erez Shinan, follow up of my PR.
It sounds like we also need to support UUID x Text?

TypeError: Incompatible types for column 'owner_id': String_UUID() <-> Text()

On my use case, it happens between MySQL UUID <> Redshift Text.
I am not sure where UUID fits the class Dialect object though

Describe the environment

Describe which OS you're using, which sqeleton version, and any other information that might be relevant to this bug.

Answer 1 · 2023-06-05T18:51:24.000Z

Any update on this issue? I'm seeing this happen on Postgres where the column is being converted to "String_UUID" in one table, but is classified as "Text" in the other table due to detection of non-UUID values.

Answer 2 · 2023-06-06T16:54:59.000Z

Any update on this issue? I'm seeing this happen on Postgres where the column is being converted to "String_UUID" in one table, but is classified as "Text" in the other table due to detection of non-UUID values.

Hi @timothyhinh79, we're not currently working on this but may in the future, in the meantime we'd happily accept a community contribution

Answer 3 · 2023-06-27T15:36:31.000Z

@dlawin - I had this exact issue when comparing snowflake and postgres and I was able to come up with a simple approach that will overcome this issue in my fork. May be that can help. I will push it out and hopefully it can overcome your issue too.

Answer 4 · 2023-08-27T06:31:17.000Z

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

Answer 5 · 2023-09-04T06:31:59.000Z

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

Answer 6 · 2023-11-02T14:25:55.000Z

@dlawin - I had this exact issue when comparing snowflake and postgres and I was able to come up with a simple approach that will overcome this issue in my fork. May be that can help. I will push it out and hopefully it can overcome your issue too.

Hey did you get that working?

Answer 7 · 2023-11-02T14:29:03.000Z

I still encounter this issue on the latest version (0.9.9) ...

Answer 8 · 2023-11-02T21:49:42.000Z

I think once we get #762 worked out, it will resolve this issue too

Answer 9 · 2023-11-02T22:09:29.000Z

I still encounter this issue on the latest version (0.9.9) ...

@MattDelac do you get this warning?

Mixed UUID/Non-UUID values detected in column {'.'.join(table_path)}.{col_name}, disabling UUID support

Answer 10 · 2023-11-02T23:30:31.000Z

I still encounter this issue on the latest version (0.9.9) ...

@MattDelac do you get this warning?

Mixed UUID/Non-UUID values detected in column {'.'.join(table_path)}.{col_name}, disabling UUID support

No now I get the following when I compare UUID (MySQL) to BINARY (Snowflake)

Answer 11 · 2024-05-17T13:42:00.000Z

Hi @MattDelac,

I'm sorry for the delay in following up on this. Thank you for taking the time to open this PR!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

W.r.t UUID x Text diffing. If that helps at all, we currently support it in Datafold Cloud with the caveat that upper/lower casing and "-" characters should match.

-Gleb