datafold/data-diff

PG connection URL has special characters in password

idling11 opened this issue · 2 comments

Describe the bug
When connect to PG, if my password has special characters, may be like '@'. The code goes to dns parser will fail to extract the right password.

My advice is: when user construct the url, he can use urllib.parser.quote to convert the special characters once. Make sure dns parser can extract right connection params. Then we use urllib.parser.unquote to convert the characters back to the connection dict.

I got a pr for this issue. And fix a mysql reconnection bug by the way. #812