datafold/data-diff

Support dbt Snowflake connection using key file itself rather than just path to key file

will-warner opened this issue · 2 comments

Is your feature request related to a problem? Please describe.
#792 enabled a Snowflake to connect using the key itself in addition to the previously allowed key path method.

dbt also supports connecting to Snowflake using the key itself as of 1.5, by providing private_key in your profile, ref.

The data-diff's dbt parser however has not been updated to parse this key from the dbt profile, meaning that you can only to connect to Snowflake via dbt using the key path method:

if credentials.get("private_key_path") is not None:
if credentials.get("password") is not None:
raise DataDiffDbtSnowflakeSetConnectionError("Cannot use password and key at the same time")
conn_info["key"] = credentials.get("private_key_path")
conn_info["private_key_passphrase"] = credentials.get("private_key_passphrase")

Describe the solution you'd like
Allow either the private_key_path or private_key to be parsed from the dbt profile.

Describe alternatives you've considered
NA

Additional context
Add any other context or screenshots about the feature request here.

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.