datalust/seq-api

Dependency on Newtonsoft.Json

beppemarazzi opened this issue · 3 comments

beppemarazzi commented

Do you plan to remove it in favor of System.Text.Json?

I've tried to do this and i got a (working?) result in a couple of hours... if it's appreciated and/or if you want ro review it i could do a PR ...

Doing this work, while doing some tests with the SeqTail sample) I've also found a dependency to Newtonsoft coming from Serilog.Formatting.Compact.Reader... so I substituted it also in that project... (i've also seen serilog/serilog-formatting-compact-reader#22 ). In this case there are a lot of test and all them are passing. So i could make a PR also for this: let me know...

nblumhardt commented

Hi Giuseppe! Thanks for dropping us a line; this is on our radar - I am not 100% sure of all the implications, so we may not necessarily be able to merge straight away, but a PR would be welcome and we will definitely dig into it 👍

brettcaswell commented

interesting, what is the merit to changing the dependency? is it to support AOT compilation?

wjrogers commented

interesting, what is the merit to changing the dependency? is it to support AOT compilation?

I would like to see Seq.Api switch to System.Text.Json because it supports source generation, which improves startup time and makes AOT and trimming possible, both of which would be great for CLI applications that interact with the Seq API.

  • 👍2