GB (UK) & USD lost currencies

Question

GB (UK) & USD lost currencies

Closed this issue 8 years ago · 4 comments

Currency codes for GB & US, at least, were lost in the jumbo commit d4e4895.

Too long to check all the edits, so maybe revert?

Answer 1 · 2016-08-01T15:19:54.000Z

Thanks for catching this, @wodow

There was a bug in the currency code script that was swallowing errors, so several currencies were being excluded silently.
Have fixed GB, US, and a few more!

Answer 2 · 2016-08-01T16:15:18.000Z

Thank you, @ewheeler

I think unit tests or simple assertions on the output would help. (I could try taking a look at that later in the month.)

Answer 3 · 2016-08-01T16:36:29.000Z

you're welcome, @wodow!

yes i agree that simple tests would help to avoid regressions.

i've created a separate issue to track here: #40
would welcome your thoughts and ideas!

cheers

Answer 4 · 2018-09-16T10:34:01.000Z

Can it be the reason taiwan is missing all its currency info?

d4e4895#diff-c1f0a2a818473ec463559fafe9ce27f5L218