datavane/datasophon

[Bug][worker]服务配置的required设置为false不会写入配置文件

Opened this issue · 0 comments

blackflash997997 commented

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

service_ddl.json中parameters的配置项如果required属性为false，那么安装服务的时候不会写入对应的配置文件

What you expected to happen

required属性应为界面的必填项，required为true时必须填写，required为false非必填，但是也应该一起写入配置文件，而且如果所有配置的required都为true也容易引起混淆，让使用者无法知道哪些参数是重要的

How to reproduce

1.服务的service_ddl.json中增加一项配置，required设置为false
2.在generators的includeParams中增加上述配置名。
3.安装服务，查看generators对应的filename配置文件中该配置是否正常写入

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct