Missing reference in "gRPC and Ambassador" to the "enable_grpc_web" flag
Closed this issue · 4 comments
ewolfman commented
Hi,
I suggest adding a reference in the "gRPC and Ambassador" to
https://github.com/datawire/ambassador/blob/master/docs/reference/core/ambassador.md#grpc-web-enable_grpc_web.
Could have saved me several hours trying to understand why grpc-web is not working in Ambassador.
Thanks.
scoyle391 commented
Hey there, I am working to address this today. Thanks for catching this, and apologies that it caused you frustration.
ewolfman commented
Thanks.
I think there is also a problem in the example for TLS: https://www.getambassador.io/user-guide/grpc/#grpc-and-tls
---
apiVersion: getambassador.io/v1
kind: TLSContext
metadata:
name: tls
spec:
hosts:
- "*"
secret: ambassador-cert
alpn_protocol: h2
Shouldn't it be 'alpn_protocols: h2'
scoyle391 commented
Good catch, I'll make sure that is included with the latest push for your issue.
scoyle391 commented
Okay, docs updated! Please let us know if you find anything else :)