dathere/datapusher-plus

v1.0.1 `install_requires` has incompatible requirements with CKAN 2.10 (ckanserviceprovider)

pdelboca opened this issue · 1 comments

pdelboca commented

Describe the bug
Installing datapusher-plus=1.0.1 installs SQLAlchemy-1.3.24 and Flask-Login 0.6.1 which both are incompatible with core CKAN.

Trying to run CKAN after installing datapusher-plus will raise an error:

ImportError: cannot import name 'Row' from 'sqlalchemy.engine' (/home/pdelboca/Repos/ckan/.venv/lib/python3.11/site-packages/sqlalchemy/engine/__init__.py)

To Reproduce
Steps to reproduce the behavior:

  1. Have a CKAN 2.10 installation (with virtual environment)
  2. Clone datapusher-plus
  3. Navigate to datapusher-plus
  4. Install the extension in the virtual environment pip install .
  5. Run CKAN

Expected behavior
Installing datapusher-plus does not install incompatible requirements with CKAN.

pdelboca commented

@jqnatividad @tino097 I'm happy to create a PR for this issue with some guidance.

I think the only problem is that ckanserviceprovider == 1.2.0 is sill listed in install_requires but I'm not sure if this has more implications.

  • 👍1