Review settings screen dom parent

Question

Review settings screen dom parent

Closed this issue 3 years ago · 4 comments

with the about button outside the 16:9 canvas area, the settings screen being constrained and scrolling in a viewport seems odd

Answer 1 · 2019-01-06T17:22:20.000Z

I'm in favor of getting rid of the 16:9 and scaling the canvas

Answer 2 · 2019-01-06T17:27:19.000Z

the idea there was to have the game’s canvas always match the best visibility the server sends (which is cropped incorrectly to a square at the moment, but the goal remains)

I always play in a non full screen window, and in s1, my first step was always to resize to find the right ratio so that my viewport wasn’t cropped, leaving me partially blind.

if we can solve that somehow without exposing the game to visibility hacks, im cool with losing the fixed ratio.

i also think its likely that if we stick with a fixed ratio, that 16:9 isnt the correct ratio

Answer 3 · 2019-01-06T20:18:11.000Z

If we make it not fixed then one screen ratio will give the best play but it will free up more room in the ui

Answer 4 · 2019-01-06T20:25:41.000Z

so how about to keep things fair, the client requests an aspect ratio from the server, and the server chooses the maximum window that it can inscribe inside a circle of radius Hook.VisibilityRadius (maybe also Hook.CameraHeight)... it then uses that for cropping your data visibility range.