spew fails to detect cycles in []interface{} values

Question

spew fails to detect cycles in []interface{} values

kortschak opened this issue 8 years ago · 6 comments

Reproducer:

package main

import "github.com/davecgh/go-spew/spew"

func main() {
    r := make([]interface{}, 1)
    r[0] = r
    spew.Dump(r)
}

See kortschak#5

Answer 1 · 2016-09-23T01:47:07.000Z

Fix for the slice case at kortschak#7.

Answer 2 · 2016-09-23T23:42:24.000Z

Nice find! I'll take at a look at the proposed fix and get this updated accordingly.

Fixing this should also fix #44.

Answer 3 · 2016-09-24T00:24:33.000Z

Note that it doesn't fix the `type t map[T]t` case. I need to spend some more time thinking on that one.

Answer 4 · 2016-09-24T02:55:07.000Z

I suspect that interface pointers in general will need to be saved since it could really happen with any compound data structure that contains an interface due to them really just being a reference.

Answer 5 · 2016-09-24T06:04:59.000Z

It can only happen with pointer or pointer-like types. So for example, you do not get the effect with type T struct { F interface{} }; v := T{}; v.F = v. So this means it's just limited to maps, slices and pointers. I have a partial fix for maps, but it need mores work.

Answer 6 · 2016-09-24T06:27:06.000Z

Here is a fix for maps kortschak#8.