davechurchill/ualbertabot

Zealot v.s. Zergling

Opened this issue · 2 comments

In UAlbertaBot/Source/CombatSimulation.cpp line 105:

if (onlyZerglings && (numZealots*3 > numZerglings))

I think you mean numZealots > numZerglings*3, right? :P

I've only looked briefly at the code, but the purpose of the function seems to be to determine whether your zealots would win versus the enemy zerglings and return a bool?

For your zealot to win you need to be fighting less than three lings, so the function should return true in that case. The line of code mentioned satisfies that condition as if three times your number of zealots is greater than the number of lings you are likely to win the engagement.

There is more than just this issue with the code, it actually isn't even being called correctly from the outside, I will fix it when I have a bit more time :)