daveoloughlin/cfmask

fillminima is better to pick up 8-neighbors instead of 4 corner neighbors

Closed this issue · 7 comments

GoogleCodeExporter commented 
Although no difference is found in the "filled" image and final mask results. 
Just need to change line 260 from "if ((ii != 0) && (jj != 0)) {" to "if ((ii 
!= 0) || (jj != 0)) {" in fillminima.py.

Original issue reported on code.google.com by songgu...@gmail.com on 24 Jun 2014 at 3:39

GoogleCodeExporter commented

Original comment by rd.alt.5...@gmail.com on 17 Jul 2014 at 2:23

  • Added labels: Milestone-future
GoogleCodeExporter commented

Original comment by rd.alt.5...@gmail.com on 29 Jul 2014 at 7:55

  • Added labels: Milestone-1.4.0
  • Removed labels: Milestone-future
GoogleCodeExporter commented

Original comment by rd.alt.5...@gmail.com on 29 Jul 2014 at 7:57

GoogleCodeExporter commented

Original comment by rd.alt.5...@gmail.com on 29 Jul 2014 at 7:58

  • Added labels: Milestone-1.4.1
  • Removed labels: Milestone-1.4.0
GoogleCodeExporter commented

Original comment by rd.alt.5...@gmail.com on 4 Aug 2014 at 6:54

  • Changed state: Started
GoogleCodeExporter commented 
Modified to include all 8 neighbors, and updated for pep8 compliance

Sending        fillminima.py
Sending        run_fillminima.py
Transmitting file data ..
Committed revision 199.

Original comment by rd.alt.5...@gmail.com on 4 Aug 2014 at 7:08

  • Changed state: Fixed
GoogleCodeExporter commented

Original comment by rd.alt.5...@gmail.com on 3 Nov 2014 at 5:36

  • Changed state: Done