daveoloughlin/cfmask

speed improvements

Closed this issue · 2 comments

This was discovered by Landsat software developers.

Inside dn_to_toa_satu a cosine calculation is being performed and then being 
used in a division.

The values used within the cosine are constant for the scene, also making the 
cosine constant for the scene.  So that only needs to be calculated one time 
earlier in the code.

Also it should be converted to an inverse so that this location in the code 
becomes a multiplication, which will also increase the speed of the application.

Original issue reported on code.google.com by rd.alt.5...@gmail.com on 18 Sep 2014 at 2:35

Original comment by rd.alt.5...@gmail.com on 29 Sep 2014 at 8:52

  • Added labels: Milestone-1.4.1
Rejected, because this is only happening 6 times or so in our code.  So very 
insignificant gain.

Original comment by rd.alt.5...@gmail.com on 3 Nov 2014 at 5:32

  • Changed state: WontFix