david415/HoneyBadger

fix ordered coalesce

Closed this issue · 1 comments

While I was working on issue number 51 #51 I came to notice that our "ordered coalesce" did not properly coalesce TCP stream segments into our reassembly ring. I was using this dev branch: https://github.com/david415/HoneyBadger/tree/51-fix-retrospective-1 and it was this extra log print statement that alerted me to the duplicate Sequenced segments being appended to our "TCP reassembly ring buffer": b4b3568

like this... for example:

2015/05/18 09:31:14 adding from ordered-coalesce (262046326, 262048014)
2015/05/18 09:31:14 adding from ordered-coalesce (262046766, 262048014)
2015/05/18 09:31:14 adding from ordered-coalesce (262048014, 262049474)
2015/05/18 09:31:14 adding from ordered-coalesce (262048014, 262049914)

fixed in this commit 4917193

does mischief want to review?