Version 5.1.0 on NPM is not the same as 5.1.0 on GitHub
Opened this issue · 6 comments
nightgrey commented
Basically, see title. The version on NPM does not have the changes from https://github.com/davidfig/pixi-viewport/releases/tag/5.1.0.
Compare package.json of https://www.npmjs.com/package/pixi-viewport?activeTab=code with https://github.com/davidfig/pixi-viewport/blob/0d3ea55c8c1c82480bfd7c654090cb34325139a4/package.json:
NPM
{
"name": "pixi-viewport",
"version": "5.1.0",
"description": "A highly configurable viewport/2D camera designed to work with pixi.js. Features include dragging, pinch-to-zoom, mouse wheel zooming, decelerated dragging, follow target, snap to point, snap to zoom, clamping, bouncing on edges, and move on mouse edges.",
"main": "dist/cjs/viewport.js",
"module": "dist/esm/viewport.es.js",
"bundle": "dist/viewport.min.js",
"types": "index.d.ts",
"directories": {
"doc": "docs"
},
"files": [
"dist",
"index.d.ts",
"src"
],
"scripts": {
"start": "serve docs/",
"dev": "rollup -w -c docs/sample/rollup.dev.js",
"dev-original": "rollup -w -c docs/original/rollup.dev.js",
"test": "floss --path test",
"coverage": "nyc mocha",
"build": "rollup -c && yarn build:types",
"build:types": "rimraf ./compile && tsc -p ./tsconfig.json --outDir compile && api-extractor run",
"docs": "rimraf ./js && tsc -p ./tsconfig-docs.json --outDir js && jsdoc -c .jsdoc.json",
"upgrade": "yarn upgrade-interactive --latest",
"prepublishOnly": "yarn build && yarn builds && yarn build:types && yarn docs",
"builds-rollup": "rollup -c docs/builds/rollup/rollup.config.js",
"builds-browserify": "browserify docs/builds/browserify/code.js -o docs/builds/browserify/index.js",
"builds-standalone": "node scripts/copy",
"builds-typescript": "rollup -c docs/builds/ts/rollup.config.js",
"builds-original": "rollup -c docs/original/rollup.config.js",
"builds": "yarn builds-rollup && yarn builds-browserify && yarn builds-standalone && yarn builds-typescript && yarn builds-original"
},
"repository": {
"type": "git",
"url": "git+https://github.com/davidfig/pixi-viewport.git"
},
"keywords": [
"PIXI",
"pixi.js",
"viewport",
"zoom",
"scroll",
"pinch",
"stage",
"bounce",
"decelerate"
],
"author": "David Figatner",
"license": "MIT",
"bugs": {
"url": "https://github.com/davidfig/pixi-viewport/issues"
},
"homepage": "https://github.com/davidfig/pixi-viewport#readme",
"peerDependencies": {
"@pixi/display": "^6.5.8",
"@pixi/interaction": "^6.5.8",
"@pixi/math": "^6.5.8",
"@pixi/ticker": "^6.5.8"
},
"dependencies": {},
"devDependencies": {
"@babel/core": "^7.16.0",
"@babel/preset-env": "^7.16.4",
"@joseph184/rollup-plugin-node-builtins": "^2.1.4",
"@microsoft/api-extractor": "^7.18.19",
"@pixi-build-tools/rollup-configurator": "^1.0.14",
"@pixi/display": "^6.5.8",
"@pixi/eslint-config": "^4.0.1",
"@pixi/events": "^6.5.8",
"@pixi/interaction": "^6.5.8",
"@pixi/math": "^6.5.8",
"@pixi/ticker": "^6.5.8",
"@rollup/plugin-babel": "^5.3.0",
"@rollup/plugin-commonjs": "^22.0.2",
"@rollup/plugin-node-resolve": "^13.0.6",
"@rollup/plugin-sucrase": "^4.0.1",
"@rollup/plugin-typescript": "^8.3.0",
"@types/offscreencanvas": "^2019.6.4",
"@typescript-eslint/eslint-plugin": "^5.5.0",
"@typescript-eslint/parser": "^5.5.0",
"browserify": "^17.0.0",
"chai": "^4.3.4",
"clicked": "^4.0.3",
"dom-ease": "^0.9.3",
"electron": "20.0.2",
"eslint": "^8.3.0",
"floss": "^5.0.1",
"fork-me-github": "^1.2.0",
"fs-extra": "^10.0.0",
"jsdoc": "^3.6.3",
"pixi-ease": "^3.0.7",
"pixi.js": "^6.5.8",
"raf": "^3.4.1",
"rollup": "^2.60.2",
"rollup-plugin-node-globals": "^1.4.0",
"rollup-plugin-peer-deps-external": "^2.2.4",
"rollup-plugin-serve": "^2.0.1",
"serve": "^14.0.1",
"settingspanel": "^2.0.0",
"tslib": "^2.3.1",
"typescript": "^4.5.2",
"yy-counter": "^2.1.0",
"yy-fps": "^2.0.0",
"yy-jsdoc-template": "^1.3.0",
"yy-random": "^1.10.2"
}
}GitHub
{
"name": "pixi-viewport",
"version": "5.0.2",
"description": "A highly configurable viewport/2D camera designed to work with pixi.js. Features include dragging, pinch-to-zoom, mouse wheel zooming, decelerated dragging, follow target, snap to point, snap to zoom, clamping, bouncing on edges, and move on mouse edges.",
"main": "./dist/pixi_viewport.umd.cjs",
"module": "./dist/pixi_viewport.js",
"type": "module",
"types": "./dist/index.d.ts",
"directories": {
"doc": "docs"
},
"files": [
"dist"
],
"scripts": {
"dev": "vite dev",
"test": "floss --path test",
"coverage": "nyc mocha",
"build": "vite build --config vite.build.ts && node ./scripts/append-mixins.js",
"docs": "vite build && rimraf ./js && tsc -p ./tsconfig-docs.json --outDir js && rimraf ./docs/dist/jsdoc/ && jsdoc -c .jsdoc.json && node ./scripts/copy",
"docs:serve": "vite preview --outDir dist/",
"upgrade": "yarn upgrade-interactive --latest",
"prepublishOnly": "yarn build && yarn docs",
"lint": "eslint . --ignore-path .gitignore",
"lint:fix": "eslint . --ignore-path .gitignore --fix",
"prepare": "husky install && yarn build",
"pre-commit": "lint-staged",
"prepack": "yarn build"
},
"repository": {
"type": "git",
"url": "git+https://github.com/davidfig/pixi-viewport.git"
},
"keywords": [
"PIXI",
"pixi.js",
"viewport",
"zoom",
"scroll",
"pinch",
"stage",
"bounce",
"decelerate"
],
"author": "David Figatner",
"license": "MIT",
"bugs": {
"url": "https://github.com/davidfig/pixi-viewport/issues"
},
"homepage": "https://github.com/davidfig/pixi-viewport#readme",
"devDependencies": {
"pixi.js": "^8.0.4",
"@typescript-eslint/parser": "^5.5.0",
"chai": "^4.3.4",
"clicked": "^4.0.3",
"dom-ease": "^0.9.3",
"electron": "20.0.2",
"eslint": "^8.3.0",
"floss": "^5.0.1",
"fs-extra": "^10.0.0",
"husky": "^8.0.3",
"jsdoc": "^3.6.3",
"lint-staged": "^13.1.0",
"pixi-ease": "^3.0.7",
"raf": "^3.4.1",
"typescript": "^4.5.2",
"vite": "4.4.10",
"vite-plugin-dts": "3.6.0",
"yy-counter": "^2.1.0",
"yy-fps": "^2.0.0",
"yy-jsdoc-template": "^1.3.0",
"yy-random": "^1.10.2"
}
}
The rest of the code is in an old state as well, which explains many of the issues currently open. I linked some of them to this issue.
ArthurTimofey commented
Yup
Workaround that worked for us is to just build it and copy the build files directly to our project for now
thonkinator commented
@davidfig any chance this could be fixed?
oyed commented
Would be great to have this re-released, just fell in to the same trap unfortunately
spassvogel commented
seems to have 5.0.3 now :) https://www.npmjs.com/package/pixi-viewport?activeTab=code
sergioisidoro commented
Same thing here. Currently lastest by semantic versioning is 5.1 on NPM, readme talks about 5.2+ but cannot find any other reference of it, and it's not on NPM (perhaps unreleased?), and master package.json points to 5.0.3
It's also a bit confusing because 5.2+ talks about supporting pixi v7.2+, but 5.1.0 already talks about supporting pixi 8.0.4.
@davidfig could you re-release the the package or clarify the situation? And is there anything we can do to help?